georust/geocoding

migrate CI to github actions

michaelkirk opened this issue · 8 comments

Build is stalled: #48 (comment)

Screen Shot 2021-08-11 at 9 35 59 AM

It seems like maybe bors is set up OK and has appropriate access, but the build status never updates.

I think this is because this repo still relies on travis-ci.

There's too much verbage here for me to be willing to read right now: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

But I believe the take away is that travis-ci is no longer an option for us unless we want to pay, so I'd recommend switching to github actions instead of travis, like we have for most of our other repositories.

Oh yeah, let's get off Travis ASAP. It should be straightforward since we don't need any exotic libraries here IIRC. I'll work on a PR tomorrow.

Although I seem to recall that GHA doesn't allow network access, which would be a spanner in the works of our (arguably not particularly useful can-we-interact-with-the-API tests).

maybe related? hyperium/hyper#1009

#48 updated hyper - maybe there is a corresponding change to make?

@elwerene - Were you able to have the tests passing locally?

maybe related? hyperium/hyper#1009

Ha I just updated reqwest and hyper

OK well I've completely confused myself now. That'll teach me to think "this will be a five minute PR". Tomorrow it is!

maybe related? hyperium/hyper#1009

#48 updated hyper - maybe there is a corresponding change to make?

@elwerene - Were you able to have the tests passing locally?

no - but not on master either :/

Drive-by remark: wouldn't it make sense to enable default-tls for reqwest if you need HTTPS?