Feature Request: Support EXTRA_GEOSERVER_OPTS
Closed this issue · 3 comments
hbruch commented
In case someone wants to start the docker container with additional GEOSERVER_OPTS, all the default opts need to be redefined.
A new ENV variable EXTRA_GEOSERVER_OPTS which gets appended to GEOSERVER_OPTS would avoid this.
Note: Dockerfile#L98 defines JAVA_OPTS, though catalina.sh suggests to rather use CATALINA_OPTS instead of JAVA_OPTS
randomorder commented
thanks @hbruch
I would split this in two:
- changing JAVA_OPTS to CATALINA_OPTS to align with what Apache Tomcat recommends
- adding the extra variable "EXTRA_GEOSERVER_OPTS" empty by default to the dockerfile and is appended to the CATALINA_OPTS by the entrypoint script right before tomcat is started with catalina.sh
hbruch commented
Yes, great, thank you!
And GEOSERVER_OPTS should be added to CATALINA_OPTS in the entrypoint.sh also, not in the Dockerfile, as currently a GEOSERVER_OPTS passed as ENV VAR is not evaluated, as JAVA_OPTS is extrapolated at build time already.
randomorder commented