geosolutions-it/osm-styles

Typo in amenities style for supermarkets

Closed this issue · 0 comments

There is an icon, shop/supermarket.svg that doesn't appear to be referenced from any style, but the OSM Carto Style does reference this in its amenities style, and supermarkets do not get an icon on the map.

However, https://github.com/geosolutions-it/osm-styles/blame/master/workspaces/osm/styles/amenities.css#L157 references type='supershieldet'. On my (old) planet import, the amenities table has no rows with type='supershieldet', but 422,369 for type='supermarket'.

This manifests with this warning in logs:

11:59:31 WARN   [wms.capabilities] - Error getting LegendURL dimensions from sample
java.lang.IllegalArgumentException: The specified mark file://symbols/shop/supershieldet.svg was not found!

I assume that this was once a mark, and an operation such as s/mark/shield/g was applied at some point early in development, converting marks to shields, and that part of supermarket got hit too, creating supershieldet.