gesellix/docker-client

Support for X-Registry-Auth in Docker run()

Closed this issue · 5 comments

Hi,
Currently dockerClient.run() fails if the specified image is hosted on private docker registry. It will be great help if somebody adds support for it.

Thanks.

@svInfra17 hey, thanks for raising that issue! I'll have a look into it soonish.

Can you give the fresh release 2017-08-10T22-04-09 a try? The run() got another parameter to pass the base64 encoded authentication. I'll need to cleanup the class and method interfaces, but you should be able to use it in the current implementation. Please leave some feedback here whether it's working in your environment or not. Thanks!

@svInfra17 did you have a chance to verify whether the new run(...) parameter would fit your needs?

Thanks @gesellix. Fix worked as expected.

great, thanks for the feedback!