Failed dockerization due to missing `VignetteBuilder`
Closed this issue · 4 comments
chainsawriot commented
The example is the package
graph <- resolve("github::chainsawriot/rang", "2023-02-27")
dockerize(graph, "~/dev/misc/localdocker", cache = TRUE)When building, it failed due to missing knitr.
I am investigating whether CRAN has the same issue.
chainsawriot commented
CRAN and bioc do not have the same issue because the Vignette(s) have been built inside the tarball.
A quick solution to this is to consider Vignette Builder for GitHub (and local)...
https://github.com/chainsawriot/rang/blob/5a313175fe589b1b09d035c7f8cad42757b2695f/R/resolve.R#L120
chainsawriot commented
#49 is important to find out this kind of bugs. Currently, these bugs are found the hard way.
chainsawriot commented
Adding knitr when VignetteBuilder is available isn't enough. It also needs rmarkdown.
chainsawriot commented
Need to investigate why R CMD --no-vignettes doesn't work