Kind 13194 info event does not match the spec
Closed this issue · 3 comments
When requesting the info event for an nwc created by nwc.getalby.com, the event content looks like this:
content: 'pay_invoice,pay_keysend,get_balance,get_info,make_invoice,lookup_invoice,list_transactions',
The spec says: "The content should be a plaintext string with the supported commands, space-separated, eg. pay_invoice get_balance."
Alby's info event contains a comma separated list.
TBH, I think that comma-separated makes more sense than space-separated. Everyone who is relying on the info event is probably already expecting a comma-separated list because Alby is the only one that has an info event with multiple methods.
Let me know if I should submit a PR to NIP 47
@gudnuf thanks for raising this.
We actually just merged @benthecarman 's PR to fix this #247 but haven't merged it yet for the nwc.getalby.com deployment (getAlby#5) and haven't pushed new versions of NWC to Umbrel/Start9 yet.
@benthecarman I tried to request this from mutiny and still only get one array item. So would changing the spec be better? I also agree comma separated makes more sense?
No we should not change the spec just because you guys had a bug, there are many implementation of nwc already and it's fixed in your guy's code.
Ok. I will close this and plan to merge the nwc.getalby.com PR.