Vertically misaligned frames on some devices
Closed this issue · 12 comments
First of all, thanks for a great library! I've been working on implementing basic payment card scanning into a react native application with good success.
There is a minor layout issue on some devices. I noticed it on a Pixel 3XL but on a standard Pixel 1 it works fine. I'm assuming it might have something to do with the notch on the Pixel 3XL since it seems to be misaligned by the height of the notch.
Which version of the library are you on? I just tried it on my 3xl simulator and it seemed ok.
Oh I think I can see a difference, it looks like you have a black strip at the top where as my version goes around the notch. This could be a build setting or library version issue. If you can help me reproduce it I'll fix it.
Can you post your project source code somewhere?
I'm not really in the position to share our complete source code, but I might be able to share certain bits if you tell me what it is you'd like to inspect.
If you'd like to try reproducing it on your end you should know we're developing a react native app that uses react navigation for navigation. This screen is the only one that has this black banner surrounding the notch. I'm running version 1.0.5001 of your library.
We don't have any experience with react native, so if you could create a "hello world" app that uses react navigation to embed the cardscan activity and we can reproduce it, we'll be able to debug and fix this much quicker.
@Abdelrhman22 and @magedsoham are you using react native also?
No we are developing a native android app
Ok, good to know. I just got my Xiaomi 7 phone today so hopefully I can reproduce it soon and post a fix.
As maged mentioned , it is native android app .
ok, fix on the way. Here is the PR #38 and we'll push a new release out either this weekend or early next week
Ok, I just shipped version 1.0.5102, try it out and let me know if it fixed it.
Perfect !! working fine now.
Ok, closing this issue