getclump/clump

Support inbuilt retries with maxRetries setting

williamboxhall opened this issue · 3 comments

williamboxhall commented

I started a PR for this idea: #53

I noticed from the docs on exception handling/retries that the user needs to manually re-request fetches that have failed. I think it would be far superior of Clump did the retries internally based on a maxRetries count and optionally a predicate: (Throwable) => Boolean to dictate if an exception is acceptable to retry on or not.

WDYT @fwbrasil

williamboxhall commented

So I'd like to be able to configure my ClumpSource like:

Clump.source(flakeyResource).maxBatchSize(60).maxRetries(3)
Clump.source(sometimesRecoverable).maxRetries(5, _.getClass == RetriableException)

or something like that

fwbrasil commented

fixed by #53

williamboxhall commented

\o/ so sexy. I think updating the README should be included in this issue