getify/JSON.minify

PyPI package?

waxlamp opened this issue · 18 comments

Thanks for creating this utility. I was wondering if there are plans to make a python package to PyPI, so that clients can install via tools like pip. That would be pretty great.

I am not a python dev so I have no plans to do so. But almost all translations of this lib to other languages have come from other contributors, and I would happily accept a PR with such a utility, for the benefit of others. <hint, hint> :)

@ronichoudhury This will happen after #23 is completed and closed.

Ah, good news! Thanks again for JSON.minify!

#26 adds all the necessary components for adding the package to PyPI. Expect this issue to be closed soon.

Just to annoy everyone with another notification.

@getify Who should be the one publishing the package on PyPI?

I don't do anything in the python world (don't even know really what PyPI is), so it wouldn't be me... someone who's invested in the python community seems like the appropriate party to do so.

@ronichoudhury I'll do this over this weekend.

@getify PyPI - the Python Package Index
Python's npm repository equivalent.

Any progress on this? I haven't been able to find the package on PyPI.

Nope. I had exams (still do, one tomorrow) so couldn't take out the time.

Ah, I see. I would be happy take on this issue, but I would need a few hints about how/where to start, as I haven't ever prepared anything for PyPI before and don't really know how it is supposed to work.
Good luck with you exams!

Hey @pradyunsg how are your exams going? ;-) Could you publish the package now? It seems all other packages with this functionality are totally outdated. it shouldn't take more than a few minutes. Let me know if you cannot do it, then I or someone else will have to push one of the other ones.

How about you, @PoByBolek? I noticed you were the last one committing a patch to the project. Would you mind doing the PyPi package if no-one else here is willing to do it?

Hey @pradyunsg how are your exams going? ;-)

The hilarious part is - still ongoing.

btw - you can use the current python branch as follows:

pip install git+https://github.com/getify/JSON.minify@python

Yes, I know. but we need to release, and then we don't want to depend on repo names or even commits on github as they could be gone at any time.

@getify @pradyunsg As you know, I created and uploaded that package [1] because this issue had not been dealt with for two years. I also added you to pypi to be able to create new releases. From your messages here it sounded like you agreed with this plan. You now changed the readme to say that there is no package on pypi -- what's the point of that? Please, just change the readme back or even better: mention the package on pypi there. You don't really need to do anything other other than changing the readme as it's all set up to work already.

The one change you requested [1], @pradyunsg , sounds like you have a faulty python installation on Windows (?), but you are more than welcome to do that change yourself if you really think it is a good idea.

[1] https://pypi.python.org/pypi/JSON_minify/0.2.1
[2] #43

sounds like you have a faulty python installation on Windows

I don't. I was wanting to do defensive coding. But what you're saying is fine with me. :)

We have this now.