Break time should not be added until user specify it
Closed this issue · 7 comments
Issue: If report is asked before the break time is elapsed, moro returns a wrong work time.
Example:
Suggestion:
Do not count the break time until user add it manually.
This could be easily done by not adding default break duration to database.
Yes that negative number has been pointed to few times. I'm not sure how to work around it.
On one hand Moro is designed to work best for a 9 to 5 work day, which for sure it need to have a lunch break of at least 30 minutes anyway :D
On the other hand, users who run it for the first time see the negative number and think it is broken.
Maybe we should always show a 0 or a positive number? For example in this screen shot it would say:
you have worked 0 minutes today. (considering the default break)
or
you haven't worked much yet today :D
IMHO those two solutions would only go around the problem.
In a normal workflow the user should add the break duration manually after the break has passed, this will make the break duration more accurate and the total time worked more intuitive. And as a side effect this will also avoid the negative worked time.
Bu the way users can set the default break to 0 if they want to be very precise.
To me it's important that the default setting works for most of people, including myself :D, but special needs can be configired easily.
I understand, what about not setting the break duration before the actual lunch break (1 p.m)?
Reports displayed before noon will not count the break duration and reports after noon will add the break duration to the total.
How about adding the break only if the work time exceeds a defined threshold?
If I work more than 6 hours i have to take a break. Don't know how many hours in other countries but a config setting for a threshold seems fine.
I also have the problem that the time for making it a full day is shown wrong.
If I enter a break time for like 59minutes for the day (moro break 59) the time for the full day is not calculated again.
Just a suggestion, why not add an optional command to mark start and end of break? it's a lot simpler for me to say "starting my lunch break" (and maybe a coffee break!) and "done my lunch break". Doesn't have to be complicate, maybe
moro break start <optional name for the break?>
moro break end