[Migration] i18n_subsites

Question

[Migration] i18n_subsites

Closed this issue 2 years ago · 18 comments

adiroiban commented 3 years ago

It would be nice to have the i18n_subsites plugin move it's own repo.

I can help with the migration.

When doing the migration please also consider moving the issues.

Not sure what to do with the existing pull requests

I some PR for i18n are great contribution, yet they were not approved (since 2017)[https://github.com//pull/841]

Thanks!

Answer 1 · 2021-12-02T05:26:37.000Z

I'd like to get involved here, too. How can I help?

Answer 2 · 2021-12-02T13:47:15.000Z

I use the i18n_subsites plugin for my blog and would like to help with the migration. Can anybody chime in about what work needs to be done? @justinmayer?

Answer 3 · 2021-12-02T13:49:59.000Z

Its all documented here: https://blog.getpelican.com/namespace-plugin-migration.html

Answer 4 · 2021-12-02T14:41:20.000Z

Thank you @georgkrause. So from https://blog.getpelican.com/namespace-plugin-migration.html it looks like we stand at the very beginning:

Migration from Monolithic Repository

Create an issue at the legacy monolithic Pelican Plugins repository and ask a maintainer to create a corresponding new repository under the new Pelican Plugins organization and invite you to join it.

If one of the maintainers could create a reop for i18n_subsites under the pelican-plugins organization then we could get started. Until then I think I'm going to downgrade my Pelican version.

Answer 5 · 2021-12-02T20:10:12.000Z

I am swamped at the moment but will endeavor to kick-start the migration process sometime this month. Thanks to everyone for their patience and understanding!

Answer 6 · 2021-12-02T23:04:50.000Z

Until then I think I'm going to downgrade my Pelican version.

But why? pelican is keeping backwards compatibility with old style plugins for a while.

Answer 7 · 2021-12-03T12:00:17.000Z

I am swamped at the moment but will endeavor to kick-start the migration process sometime this month. Thanks to everyone for their patience and understanding!

Thank you for getting back to us @justinmayer, just let us know when it is ready.

Until then I think I'm going to downgrade my Pelican version.

But why? pelican is keeping backwards compatibility with old style plugins for a while.

Upgrading pelican broke my site so I assumed that was the issue, but maybe it's something else. I will debug it, thank you for the heads up @avaris.

Answer 8 · 2022-02-13T17:22:24.000Z

@justinmayer Any news about this?

Answer 9 · 2022-03-22T08:54:59.000Z

I filtered the subdirectory in its own repository: https://github.com/georgkrause/i18n_subsites

I am willing to transfer the project, just let me know!

Answer 10 · 2022-03-22T08:57:02.000Z

As far as I can tell there are 6 open merge requests regarding i18n_subsites, I will try to review them in the next days and merge them into my fork.

Answer 11 · 2022-03-22T10:53:01.000Z

@georgkrause thanks. feel free to ping me if you need any help with testing. I don't have much free time, and I might already used a very customized pelican to get my i18n site working, but I will try to help.

Answer 12 · 2022-03-22T11:09:49.000Z

@adiroiban Jeah for me its almost the same, which is why I want to cleanup the situation. I cannot stand pulling a huge set of submodules and patching them to make it work any longer. It would be nice if you would use my fork as well, what needs to be merged to make this possible for you? So I can start with reviewing this first.

Answer 13 · 2022-03-23T10:35:59.000Z

Thanks George for the work.
I don't remember what part was not working. I looked into this 6 month ago, and I don't know when I will have time to look into this again.

But definitively, next time I will work on the project in which pelican i18n is used, I will switch to use your fork... that I hope will grow into de-facto plugin.

I did a quick copy/paste for my fork

https://gist.github.com/adiroiban/2019f82cc6b6a335ffdd93a06e7143cc

Answer 14 · 2022-03-23T11:16:28.000Z

Do I get this right? This is a dump of what you have running in production? This helps a lot, lets integrate this :)

Answer 15 · 2022-03-23T16:34:06.000Z

I think there are 2 main changes in my fork.

First is this change for which I have already created a PR #1350

The second one, is support for gettext inside the main SITE dict... but maybe I am wrong and this is already standard functionality.

SITE = {
    'author': _('A Team'),
    'title': _('Delivering great result each time.'),
    'description': _(
        'The A Team works all day and all night long for nothing.'
    ),
}

Answer 16 · 2022-08-10T09:21:05.000Z

@adiroiban @georgkrause @haplo
So I happened to merge some of the more uncontroversial PRs (#1299, #1347, #1350), cleaned up and migrated the whole repo, and published a pre-alpha package on PyPI:

https://pypi.org/project/pelican-i18n-subsites

The project repository currently sits here: https://github.com/rschiang/pelican-i18n-subsites. Could you help verify if it works as expected, so we can ask @justinmayer to move it into @pelican-plugins and make us maintainers? 👀

Answer 17 · 2022-09-23T10:13:17.000Z

Hi. Sorry for the delay.
I don't have time now to look into this... I did the website changes a long time ago as an experiment.

At work, we don't yet have a multi-lingual website, it was more of an experiment,

Once this goes into production I will check your repo. I started it and I hope I will not forget about it :)

Thanks for putting this all together.

Answer 18 · 2022-09-23T10:13:40.000Z

Let me close this as all work should be done in the separate repo.