Templates not included

Question

NotSqrt opened this issue 9 years ago · 7 comments

Hello,

This project needs a MANIFEST.in to declare the inclusion of html files..

Thanks,

Answer 1 · 2015-09-30T16:28:42.000Z

A MANIFEST.in file is only needed for an sdist bundle, which we don't do since we recommend installing from source.

Were you hitting an issue with this not existing some how?

Answer 2 · 2015-09-30T16:37:38.000Z

We might still need the manifest. Either way should add it.

On Wed, Sep 30, 2015 at 9:28 AM -0700, "Matt Robenolt" notifications@github.com wrote:

A MANIFEST.in file is only needed for an sdist bundle, which we don't do since we recommend installing from source.

Were you hitting an issue with this not existing some how?

—
Reply to this email directly or view it on GitHub.

Answer 3 · 2015-09-30T17:11:04.000Z

I did pip install https://github.com/getsentry/sentry-auth-google/archive/master.zip, and the templates were not installed (pip version 7.1.0).

Answer 4 · 2015-09-30T17:14:15.000Z

Ah, if you threw a -e in front of that it would. :) But that's fair, we'll fix it up. Thanks for the feedback.

Answer 5 · 2015-09-30T17:24:44.000Z

Yay!

@dcramer Is provider authentication supposed to work yet ?
I tested this morning, but in https://github.com/getsentry/sentry/blob/b212b1386666bcf9e1ca97f9ced3a273d9e6c3b7/src/sentry/templates/sentry/organization-login.html#L19 , the btn-login-{{ provider_key }} button doesn't do anything..

Answer 6 · 2015-09-30T17:30:25.000Z

@NotSqrt you're using the latest version of Sentry?

Answer 7 · 2015-09-30T17:38:18.000Z

I tried the current master, yes 😄