Remove FirstChanceException workaround
jamescrosswell opened this issue · 1 comments
jamescrosswell commented
See comment here:
Since the original bug has been fixed, we shouldn't need the workaround anymore.
bitsandfoxes commented
Coming through a support ticket:
System.NullReferenceException: Object reference not set to an instance of an object.
at void SentryExceptionExtensions.SetSentryMechanism(Exception ex, string type, string description, bool? handled) in SentryExceptionExtensions.cs:line 38
ex.Data[Mechanism.MechanismKey] = type;
at void WinUIUnhandledExceptionIntegration.WinUIUnhandledExceptionHandler(object sender, object e) in WinUIUnhandledExceptionIntegration.cs:line 134
exception.SetSentryMechanism("Microsoft.UI.Xaml.UnhandledException", description, handled);
at Delegate EventState.GetEventInvoke()+(object sender, UnhandledExceptionEventArgs e) => { }?
at int UnhandledExceptionEventHandler.Do_Abi_Invoke(IntPtr thisPtr, IntPtr sender, IntPtr e)
Since Data
is an empty collection by default I suspect the exception itself is null.
Going up the callstack we get to this:
sentry-dotnet/src/Sentry/Integrations/WinUIUnhandledExceptionIntegration.cs
Lines 121 to 125 in 800774c
Since this workaround now sports a bug we should re-prioritize this.