Support TanStack Router for SolidJS

Problem Statement

I see that Sentry has support for TanStack Router for React here. Can there be time spent to also support TanStack Router for Solid?

Solution Brainstorm

React and Solid have JSX in common so I'm hoping much of the work Sentry has done to support TanStack Router for React should be able to carry over for the Solid implementation.

Additional Context

_{Tip: React with 👍 to help prioritize this improvement. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.}

JS-953 Support TanStack Router for SolidJS

Hey @thedanchez thanks for reaching out! Gonna ping @andreiborza here 👀

Thanks @chargome! Looking forward to hearing back @andreiborza! I am in the process of building out a greenfield enterprise application using TanStack Router for Solid and would love to use Sentry as our error, monitoring and tracing solution. Could really use your help.

Hey @thedanchez, we're waiting a bit on traction for this. We currently don't have concrete plans to move ahead with this, but PRs are welcome if you're interested in contributing.

For anyone else, if you'd like to see this get worked on please upvote the issue.

Hey @andreiborza, if I was interested in getting this over the edge, where can I reference the Sentry implementation for TanStack Router for React? I'm sure a lot of the work for this will mirror that since they are built on the same core agnostic foundation.

Ah, nvm, found it here:

sentry-javascript/packages/react/src/tanstackrouter.ts

Line 23 in d7538cd

export function tanstackRouterBrowserTracingIntegration(

Is there any caveat I should be aware of? I'll just follow the same react src structure and create a tanstackrouter.ts module under the solid src directory.

Yes, basically that. I think you could copy that verbatim. We also want to ensure this gets its own export like the solidrouter here:

sentry-javascript/packages/solid/package.json

Lines 32 to 40 in d7538cd

    
           "./solidrouter": { 
        
             "import": { 
        
               "types": "./solidrouter.d.ts", 
        
               "default": "./build/esm/solidrouter.js" 
        
             }, 
        
             "require": { 
        
               "types": "./solidrouter.d.ts", 
        
               "default": "./build/cjs/solidrouter.js" 
        
             }

Perfect. That's helpful, thanks! I just copied the vendor-types from the React version along with the tanstackrouter.ts module and replaced all mention of react with solid. Going to put up a draft PR for review so we can see what else we need

Here is the PR: #17735

@andreiborza Let me know if there is anything else you need from me on the above. Happy to help however I can as I feel it's important for Sentry to have full TanStack Router support across all flavors of it.

Do we need to add a docs page under Solid like the React one has here?

@thedanchez thank you for the contribution, I'll review today.

Yes we do need a docs page for it, we have this one for Solid Router: https://docs.sentry.io/platforms/javascript/guides/solid/features/solid-router/

Here's our docs repo: https://github.com/getsentry/sentry-docs

Contributions are again welcome, but we can also take care of it. Let me know.

Hey @andreiborza thanks for that reference and apologies for the delay! The documentation PR can be found here

Thanks! Sorry I didn't yet get to it. Will take a look at it this week.

This has been released with 10.20.0.

	"./solidrouter": {
	"import": {
	"types": "./solidrouter.d.ts",
	"default": "./build/esm/solidrouter.js"
	},
	"require": {
	"types": "./solidrouter.d.ts",
	"default": "./build/cjs/solidrouter.js"
	}