getsentry/sentry-ruby

[Plan] Version 6

Opened this issue · 8 comments

st0012 commented
  • Drop support of Rails 5.0 & 5.1
  • Drop support of Ruby 2.4
  • Drop some configuration options
    • async - #1522
    • linecache - I guess no one is using this. if you do, please let me know your use case
    • exclude_loggers - this only works with sentry_logger breadcrumb logger. given that probably not many people use the logger, there should be even fewer (or no) people use this option.
  • Event#to_hash only returns a string key hash.
    • Currently, Hash-form events have string keys if they're generated from #to_json_compatible. But #to_hash returns a symbol key hash. So it can be confusing to users when dealing with events in callbacks.
  • Remove hub argument from Transaction#finish
  • Advanced Sidekiq reporting control
    • We may support more fine-grained control on retried jobs reporting. For example,
      • attempt_threshold - Only start reporting after the nth retry failed - #1632
      • reportable_retries - Only report a number of times for retry failures - #1570
  • Type signature (maybe)
  • Fix stacktrace trimming #2018

（feel free to add your feedback/request)

dlibanori commented

Please, drop faraday. As utility library you shouldn't set any gem your client may be using. Right now I have to "upgrade" my farady to migrate from sentry-raven to sentry-ruby :(

  • 👍1
st0012 commented

@dlibanori the version requirement on faraday is to make sure it'll always work with the SDK. you can use sentry-ruby-core to bypass the limitation. but depending on the faraday version you have, it may or may not work.

github-actions commented

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

AlexWayfer commented

Update Faraday to version 2?

st0012 commented

@AlexWayfer Faraday is no longer the SDK's dependency after version 5.

AlexWayfer commented

@AlexWayfer Faraday is no longer the SDK's dependency after version 5.

Sorry, my bad, there left other dependencies after 4→5 update.

  • 👍1
adis-io commented

Hi, any dates on when sentry-raven stops working

jeffwidman commented

Looks like this was scheduled for removal in v5 but accidentally left in, so should probably ship with v6?