getsentry/sentry-ruby

Sample rate override ignored when set to 0

Closed this issue · 5 comments

azaslavsky commented

Issue Description

At https://github.com/search?q=repo%3Agetsentry%2Fsentry-ruby+valid_sample_rate&type=code, setting sample_rate to 0 does not work.

Reproduction Steps

This was reported to us by a downstream user of the SDK.

Expected Behavior

One should be able to set the sample rate to 0.

Actual Behavior

The sample rate override is ignored.

Ruby Version

--

SDK Version

--

Integration and Its Version

No response

Sentry Config

No response

bauffman commented

We're having the same issue over here. We're using ruby 3.1.5 and the latest versions of the sentry gems.

sl0thentr0py commented

@azaslavsky @bauffman what do you mean by 'does not work'?

  • 👍1
getsantry commented

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

bauffman commented

What I mean is that the system keeps sending logs to Sentry even though the sample rate is 0.0.

sl0thentr0py commented

@bauffman I need you to be more precise when you report a problem. 'Does not work' is not helpful for me to reproduce or analyze the issue.

  • what is your app? a rails app?
  • what is your sentry init configuration?
  • are you talking about errors with sample_rate 0 or performance with traces_sample_rate 0?
  • ideally give me a clear reproduction case that shows the problem so I can fix or tell you what to do