tracing: Propagate span to tags
frjonsen opened this issue · 2 comments
frjonsen commented
This is related to what was solved in this PR: #629
Currently all spans are propagated to context. I feel what's missing is that spans named "tags" should instead be propagated to tags in Sentry.
At a glance it should be sufficient to add a check in the arms of this match
sentry-rust/sentry-tracing/src/converters.rs
Lines 71 to 88 in acba14f
tags
, then the key should be formatted as tags.{}
, rather than the current {}.{}
.Swatinem commented
TBH, this feels a bit too magical, and might lead to some surprises as well.
Especially if you happen to have such a function:
#[tracing::instrument]
fn tags(arg: ()) {
}
This is an interesting idea though, and may be something to put more thought into.
szokeasaurusrex commented
Closing per @Swatinem's comment