getting-things-gnome/gtg

Changing Start Date doesn't remove task from Actionable view

SqAtx opened this issue · 2 comments

This is related to other problems that I've noticed/filed on the megabranch, but I couldn't find a duplicate here. Similar to diegogangl#21 in that the DB has the correct data, but the UI hasn't been updated.

This is on commit 2ecc997

Steps

  • Go to the Actionable tab
  • Select a task (single click)
  • Click "Start Tomorrow"

or:

  • Go to the Actionable tab
  • Open a task (double click)
  • Change the start date to a date in the future

Expected

The task disappears from the Actionable view.

This is the behaviour in GTG 0.6.

Actual

The task is still visible in the Actionable view. I can update the view and make the disappear by:

  • switching to (for example) Open and back to Actionable
  • marking an Actionable task as done

Interestingly, the Actionable tab is updated as expected when you mark a child task as done and it unblocks its parent. The child disappears from the view (because it's now done) and the parent appears (because it's now actionable).

Side note: the other way doesn't work, but I'll create another ticket for it when I can take the time to reproduce it properly. If you add a child to an Actionable task, the now parent is supposed to disappear and the new child to appear. I think in 0.7, the child doesn't appear unless I actually restart GTG. But I'll confirm that later in a different ticket.

Actually, I just had to do it again, and the other way indeed doesn't work, but it might be the same problem as I described in the ticket description. When I add a child to an Actionable task, the now parent is supposed to disappear and the new child to appear. But neither happens until I go to Open and back to Actionable.

This came back :( I'm now on f501dfb

From the Actionable view:

  • Clicking on the checkbox to mark a task as done doesn't make the task disappear:
    image
    Going to Open and back to Actionable makes is disappear.

  • Adding a child to a task doesn't make the parent disappear:
    image
    image
    Going to Open and back to Actionable again does the right thing:
    image

  • Clicking on a task and clicking Start Tomorrow doesn't make it disappear. Again, going to Open and back to Actionable works.

I ran a git bisect for the last problem. It indeed worked after 6ceec80. It found commit a89f715. And indeed, reverting that comit on master fixes that problem.

While bisecting, I also noticed #1130