gg-scm/gg

gerrithook doesn't appear to work when run from a subdirectory

Closed this issue · 1 comments

gerrithook doesn't appear to work when run from a subdirectory. Repro case is straightforward and I'm fairly certain of it.

This appears to be an issue with older versions of Git: the regression test I've developed for this fails on Git 2.12.5, but not 2.13.7. It appears as though git rev-parse --git-common-dir returns incorrect results. When in a subdirectory foo, Git 2.13.7 yields ../.git whereas Git 2.12.5 yields foo/.git (which is all flavors of wrong).