Don't take testing.TB in cmd/gg tests
zombiezen opened this issue · 0 comments
zombiezen commented
cmd/gg.newTestEnv
takes in a testing.TB
:
It would be better to avoid doing this: if it needs to log, then it should take in a logging interface. However, it does do auto-skipping:
... which would be annoying to replicate across all test sites, but this is what internal/git
does.