issues with running make install
grkblood13 opened this issue · 3 comments
grkblood13 commented
Running make install doesn't install libggmorse-common-sdl2.so and libimgui-sdl2.so. Additionally the example executables don't get placed in /usr/local/bin (if they even should?).
The following will fix all of this but you probably have a much cleaner way of doing this.
# build install (optional)
sudo make install
sudo cp examples/libggmorse-common-sdl2.so /usr/local/lib
sudo cp examples/third-party/imgui/libimgui-sdl2.so /usr/local/lib
sudo cp bin/ggmorse-* /usr/local/bin
cd /usr/local/bin
sudo patchelf --set-rpath /lib:/lib64:/usr/local/lib ggmorse-*
ggerganov commented
Hmm are you sure they are not installed? I just tried using a clean build and they do get installed in /usr/local/
:
$ sudo make install -j
[ 6%] Built target ggmorse-common
[ 17%] Built target ggmorse
[ 34%] Built target imgui
[ 41%] Built target malloc-count
[ 55%] Built target ggmorse-from-file
[ 55%] Built target ggmorse-to-file
[ 72%] Built target imgui-sdl2
[ 79%] Built target ggmorse-common-sdl2
[100%] Built target ggmorse-gui
Install the project...
-- Install configuration: "Release"
-- Installing: /usr/local/lib/libggmorse.so
-- Set runtime path of "/usr/local/lib/libggmorse.so" to "/usr/local/lib"
-- Installing: /usr/local/lib/libggmorse-common.so
-- Set runtime path of "/usr/local/lib/libggmorse-common.so" to "/usr/local/lib"
-- Installing: /usr/local/lib/libggmorse-common-sdl2.so
-- Set runtime path of "/usr/local/lib/libggmorse-common-sdl2.so" to "/usr/local/lib"
-- Installing: /usr/local/lib/libimgui.so
-- Set runtime path of "/usr/local/lib/libimgui.so" to "/usr/local/lib"
-- Installing: /usr/local/lib/libimgui-sdl2.so
-- Set runtime path of "/usr/local/lib/libimgui-sdl2.so" to "/usr/local/lib"
-- Installing: /usr/local/bin/DroidSans.ttf
-- Installing: /usr/local/bin/ProggyTiny.ttf
-- Installing: /usr/local/bin/fontawesome-webfont.ttf
-- Installing: /usr/local/bin/ggmorse-gui
-- Set runtime path of "/usr/local/bin/ggmorse-gui" to "/usr/local/lib"
grkblood13 commented
Weird, it mostly worked with a fresh clone just like you said. ggmorse-to-file and ggmorse-from-file still didn't get installed though.
ggerganov commented
I see - should be fixed on master
now. Thanks for reporting this