Branch ssd1306 - Untested Driver
Closed this issue · 6 comments
The code in the branch ssd1306 is untested as we do not have a click module that in undamaged. Once they arrive, we can test this code and open a pull request.
This appears to be the same driver as on the BrainPad? Just using SPI instead of I2C. If that's the case, let's close this and add an issue to add support for the SPI interface.
Even if it is the same, would we not still need an independent driver for this display if it is not used on the BrainPad? Perhaps we should add the I2C to this one and just call this in the BrainPad driver?
The driver we have here now is independent of the BrainPad. There shouldn't be anything about the BrainPad in this repo
I mean keep this an independent driver and have both I2C and SPI. But in the libraries repo, we call this driver into the BrainPad library code and just use an instance of this there. I am assuming by the above comment that you are suggesting close this driver and just add the SPI interface to the BrainPad, or am I misunderstanding something?
The BrainPad driver has already been updated to use this new driver here. I do mean to close this driver and add the SPI interface to the driver in this repo, not the BrainPad library.
Ok. I did not realize that you had done that. I will do that. I will close my branch and add an issue to add the SPI support to the current driver.