ghiscoding/Angular-Slickgrid

Angular slickgrid upgrade does not working

HafsaAsif opened this issue · 3 comments

Describe the bug

I am using angular-slickgrid 6.0.0 version in Angular 16. When I tried to upgrade angular slickgrid version from 6.0.1, my project compilation fails and give me this error
CompileIssue

Reproduction

Any angular app with version : 16
Angular slickgrid with version : 6.0.0
just run command : npm install angular-slickgrid

It updates the package.json with version : 6.6.6

Navigate to angular 16 project --> Run: ng serve
Then the above described issue will be generated.

Expectation

No response

Environment Info

Angular CLI: 16.2.10
Node: 18.18.2
Package Manager: npm 9.8.1
OS: win32 x64


Angular: 16.2.12
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, localize, material, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1602.10
@angular-devkit/build-angular   16.2.10
@angular-devkit/core            16.2.10
@angular-devkit/schematics      16.2.10
@angular/cli                    16.2.10
@ngtools/webpack                16.2.10
@schematics/angular             16.2.10
rxjs                            7.8.1
typescript                      5.1.6
zone.js                         0.13.3

Validations

It's not an Angular-Slickgrid but rather a DOMPurify bug, there's an open issue regarding this problem, they will hopefully have a fix soon. You can see that I have the same problem when Renovate ran 2 days ago, you can see the CI workflow error here which is the same build problem as you're getting. For now what you can do is set the DOMPurify version to the previous working version 3.0.6 (because 3.0.7 released 2 days ago has the bug), you can use npm/pnpm/yarn override to set it to the previous version.

For example with yarn resolution (make sure to remove the caret ^ in your override (in yarn they use resolutions, in npm/pnpm they use overrides)

// package.json
{
  resolutions: {
    "dompurify: "3.0.6"
  }
}

Note that even if you downgrade Angular-Slickgrid version, you'll get the same problem unless you use the override shown above. So I strongly suggest you do the override, I will keep this issue open until DOMPurify has a fix

DOMPurify pushed a new version 3.0.8 which fixes the issue, my Renovate PR #1346 is also passing which confirms that the issue is fixed. So you can update without the need for the override anymore. Cheers ⭐

Hello, I had tried ur given solution and it is working now. Thanks a lot for your effort!