ghooks-org/ghooks

Cleanup modified hooks after npm uninstall

vitalets opened this issue · 8 comments

vitalets commented

I'm using ghooks for several projects but for one project I decided to uninstall it.
After npm un ghooks I'm getting error on every commit:

ghooks not found!
Make sure you have it installed on your "node_modules".
Skipping git hooks.

Is it possible to cleanup modified hooks automatically?
thx!

kentcdodds commented

I just delete my .git/hooks directory. I wonder if there's an uninstall script that we could use...

  • 👍6
  • 🎉1
vitalets commented

Yes, sure i can do it.
But maybe it's better to keep hooks/*.sample for the future.
I end up with the following command that removes all hooks not ending with .sample:

cd .git/hooks
ls | grep \.sample -v | xargs rm

I think it could be useful to add uninstall section to readme.

  • 👍5
  • 🎉1
kentcdodds commented

I think it'd be even better to add a postuninstall script in our npm scripts just like we have an install script.

Would you like to makeapullrequest.com? Make sure that it works on windows too!

  • 👍1
okonet commented

Also run into this one.

kentcdodds commented

I definitely just recommend switching to husky: #166

Deleted user commented

@kentcdodds after 7 months of husky perhaps you could share your experiences as to how it works under the scenario described in the OP?

kentcdodds commented

Honestly, this is never really something I notice. But I'm pretty sure that husky uninstalls properly IIRC.

Deleted user commented

Thanks Kent, will keep that in consideration. For now the messaging in place should suffice. Pulls welcome.