ghost1372/HandyControls

DangerBrush for TextBox not applied

dthoeni opened this issue · 2 comments

Describe the bug

In the latest release a TextBox inside A GridView wont get rendered with a red border on error.
I suspect this bug was introduced with the following commit:

Commit: 8e707a6 [8e707a6]
Parents: 322e366
Author: NaBian 836904362@qq.com
Date: Montag, 23. Jänner 2023 22:27:50
Committer: NaBian
Commit Date: Sonntag, 29. Jänner 2023 23:49:17
enhance: optimize input elements.

Steps to reproduce the bug

Put a handyControl:TextBox inside a DataGrid and provoke a ValidationError

<DataGridTemplateColumn Header="Name"> <DataGridTemplateColumn.CellTemplate> <DataTemplate> <hc:TextBox MinWidth="75" hc:InfoElement.ShowClearButton="True" Text="{Binding Name, ValidatesOnDataErrors=True, UpdateSourceTrigger=PropertyChanged}"/> </DataTemplate> </DataGridTemplateColumn.CellTemplate> </DataGridTemplateColumn>

Expected behavior

Like in release 3.4.4 DangerBrush should be applied to the control.

Screenshots

Version 3.4.4
image

Version 3.4.5
image

NuGet package version

HandyControls (Custom version) 3.4.5

IDE

Visual Studio 2022

Framework type

.Net 7.0

Windows version

Windows 11 (22621)

Additional context

No response

I figured out, that this problem is caused by changes to The TextBoxPlus_(Top/Left)_Template.
The border element was moved into a Grid and is not visible anymore.

Reported on main project