gianni-rosato/svt-av1-psy

[BUG] --progress 3 is showing ASCII escape codes as instead of colors on Windows Builds

agressiv opened this issue · 5 comments

Overview
--progress 3 is showing ASCII escape codes as instead of colors on Windows Builds

Branch
In which branch does the issue appear to be occurring?

  • master
  • testing

Reproduction
Steps to reproduce the behavior:

  1. Download the 2.0.0 A Windows binary from this github repo.
  2. Run an encode with --progress 3 on Windows

Expected behavior
Colors show for various encoding methods without ASCII escape characters.

Terminal Output
Encoding: ←[33m 49 Frames←[0m @ ←[32m29.94←[0m fps | ←[35m209.13 kb/s←[0m | Time: ←[36m0:00:02←[0m | Size: ←[31m0.24 MB←[0m

Platform (please complete the following information):

  • Windows 11 version 10.0.22631.3447
  • Clang/GCC Version - N/A. I'm not compiling anything, i'm downloading precompiled binaries.

Version String (please complete the following information):

  • Run SvtAv1EncApp --version and copy the result:
    SVT-AV1-PSY v2.0.0-A (release)

Additional context / Relevant Files
N/A. Pretty straightforward. Purely cosmetic bug. I've tried at least 5-6 different console fonts, in cmd and powershell. Linux build seems to be fine.

Hi, please fill out the bug report issue template in its entirety so we can better reproduce your issue in order to understand what's going on.

i've retrofitted my top comment.

Thanks so much for the extra info. I've been able to confirm that some users are experiencing the same issues on Windows 10, so I will try to reproduce this on W11 & get back to you with next steps or a fix. Thanks for your patience!

tbh don't really need the color. It's just great getting the extra stats that vanilla SVT doesn't have!

This has now been fixed in the testing branch via 113d9ee which just disables ANSI escape codes for Windows. This will be live on master as soon as testing is merged. Thanks for your patience!