gilmatok/Destiny

[Crash] RemoveItem index out of bounds

Bia10 opened this issue · 0 comments

Bia10 commented

protected override void RemoveItem(int index) in MapDrops.cs gets called with index outside total count of base(map).Items. This used to crash game server, however since pull #17 the problem is transformed into problem of permanent existence of (some) items on map rather then crash.

This and the other crash reported are two main sources of Destiny being unstable, beside that there are only minor events triggering crash due to not yet being implemented/handled. Also id love to know from where did you pull the data on the packet structure, am i supposed to assume that you got it right? because sometimes i wonder and other sources also disagree.