gimsieke/xspec

r167 breaks xquery test generation

Closed this issue · 3 comments

The signature of template x:output-scenario in generate-common-tests.xsl was 
changed in r167, and no longer matches how it is called from generate-query-
tests.xsl.  That stylesheet fails to compile when called.

Without really understanding that bit of underlying code, I've attached a 
patch to generate-query-test.xsl that appears to fix it.  :)

Original issue reported on code.google.com by jsulak@gmail.com on 10 May 2010 at 10:26

Attachments:

I went ahead and committed the change (r169), since it looks like others were 
running 
into the problem as well.  Florent, feel free to correct any mistakes.

Original comment by jsulak@gmail.com on 18 May 2010 at 7:45

Thanks James.  I finally had the time to have a look at this issue.  Thanks for 
the report, and the fix!  Actually I 
had a few pending changes waiting to be checked in, sorry about that.  Actually 
you were pretty close, the only 
change is that the mode you used generates global variable declarations, but in 
this context we need a local 
variable :-)

I've just checked in r170.

For the records, this change is to handle variables declared in a scenario 
*before* the x:call element (so usable 
in x:call/x:param as well as in x:expect e.g.)

If this suites your needs, can you close this issue, please? (i.e. set the 
status to "Verified")

Original comment by fgeorges on 18 May 2010 at 10:28

  • Changed state: Fixed
Cool.  Works on my machine.

Original comment by jsulak@gmail.com on 18 May 2010 at 10:32

  • Changed state: Verified