gin-gonic/gin

Graceful Restarts?

pyrossh opened this issue · 7 comments

pyrossh commented

How about integrating zero downtime restarts in gin server? Maybe using endless?

https://github.com/fvbock/endless

manucorporat commented

Adding a library like that may opens a new world of issues. I am not considering a built-in support for this right now. Even though, I am interested in zero downtime restarts.

If you want to start using endless right now, just do this:

router := gin.Default()
router.GET("/", handler)
// [...]
endless.ListenAndServe(":4242", router)
elliotlings commented

I don't think it should be included in the library, it may be confusing for people just getting started with the library and may become an issue during development. I'm currently doing what @manucorporat suggested.

shotcat commented

good tools is quick my develop speek!

jacktuck commented

Manners by the folks at BrainTree seems like an alternative to endless 😃

appleboy commented

@jacktuck Thanks. I already create new PR #561 to update README.

  • ❤️2
walleliu1016 commented

Adding a library like that may opens a new world of issues. I am not considering a built-in support for this right now. Even though, I am interested in zero downtime restarts.

If you want to start using endless right now, just do this:

router := gin.Default()
router.GET("/", handler)
// [...]
endless.ListenAndServe(":4242", router)

endless not supported under windows platform.

BlaiseAntony commented

Why not add this functionality in gin lib itself? Do we have any blocker for it?