ginowu7/CleanLocalizableExample

Errors when spaces in project name

Opened this issue ยท 2 comments

Thanks for sharing this script, it's much needed! ๐Ÿ‘

The script errors out if there's a space in the project name. I tried escaping the space but no luck.

For example, project_name="My Project"

== Sorting localizable files: ./My ==
sed: ./My: No such file or directory
sort: No such file or directory
sed: ./My: No such file or directory
== Checking if keys match in localizable files: ./My ==
sed: ./My: No such file or directory
sed: Project/en.lproj/Localizable.strings: No such file or directory
sed: ./My: No such file or directory
./Scripts/clean_localizable.sh: command substitution: line 28: syntax error near unexpected token `('
./Scripts/clean_localizable.sh: command substitution: line 28: `diff <(echo "$base_keys") <(echo "$localizable_keys")'

== Checking keys not used in code ==
sed: ./My: No such file or directory
sed: Project/en.lproj/Localizable.strings: No such file or directory
== Checking keys not included in localizable ==
sed: ./My: No such file or directory
sed: Project/en.lproj/Localizable.strings: No such file or directory
Command /bin/sh emitted errors but did not return a nonzero exit code to indicate failure

Hey @basememara ! Good catch: here's the PR : https://github.com/ginowu7/CleanLocalizableExample/pull/5/files

Let me know if that looks good to you. Go ahead and approve and I'll merge it in -

Thanks

still, the issue persists and I am not able to run the script with project name have space in-between.