Implement `axes` and `iterate`

Question

Implement `axes` and `iterate`

Opened this issue 2 years ago · 6 comments

This package currently implements only the basic AbstractArray interface, but not the optional methods such as iterate or axes, which leads to some funny (and wrong) results.

Answer 1 · 2022-05-17T00:06:47.000Z

Mostly addressed by f1e687f, 4f90098, and fe8a413. The main remaining issue I see is that now collect(::StarWarsArray) fails (it didn't use to up to 8e41eef)

Answer 2 · 2022-05-30T19:35:35.000Z

axes is supposed to return

a tuple of AbstractUnitRange{<:Integer} of valid indices

Answer 3 · 2022-05-30T23:05:30.000Z

How do you think you can do a AbstractUnitRange{<:Integer} for this indexing?

Answer 4 · 2022-05-31T06:06:27.000Z

I'm just quoting @mbauman here

https://discourse.julialang.org/t/offsetarrays-inbounds-and-confusion/81295/50

Answer 5 · 2022-05-31T06:14:13.000Z

I suppose that axes only has to return valid indices. They do not have to be in iteration order.

Answer 6 · 2024-02-12T22:28:30.000Z

They do not have to be in iteration order.

Can't we just add that requirement to the AbstractArray docs? It seems like a complication and I'm not seeing much advantage.