giorgiosironi/eris

Float and String generators won't work in PHP 7

Closed this issue · 2 comments

Hi,

Float and String won't be valid class names in PHP 7.

http://php.net/manual/en/reserved.other-reserved-words.php

They could be renamed to something like FloatGenerator and StringGenerator. If you think those are good names I could create a PR for this.

Yes, these are good names.it's a diffused convention to use "{$qualifier}{$interface}" and $interface is Generator here.

Considering closed by #56