git-commit-id/git-commit-id-maven-plugin

Backport the fix for Maven 3.9.2 warnings to 5.0.x branch

xak2000 opened this issue · 4 comments

xak2000 commented

Describe the release details (required)

There is issue #615 that is fixed in 6.0.0.

Is it possible to backport the fix #616 to the 5.0.x branch (e.g. with Release 5.0.1)?

The reason for this request is that git-commit-id-maven-plugin 5.0.0 is used by Spring Boot 3.1.x release that happened not long time ago, and in the near future will not be updated to git-commit-id-maven-plugin 6.0.0 because it's a major version change.

See spring-projects/spring-boot#35605 for the context.

TheSnoozer commented

I have created a version5.x-branch now.

For documentation purposes I have created the branch from a9dd793 and not the tag v5.0.0. Main reason is that this commit is essentially just the already updated pom version and an update in the readme which should be irrelevant.

* a9dd793 - (1 year, 10 months ago) https://github.com/git-commit-id/git-commit-id-maven-plugin/issues/558: update version in readme - TheSnoozer
* 316d3fc - (1 year, 10 months ago) [maven-release-plugin] prepare for next development iteration - TheSnoozer
* 39a8b54 - (1 year, 10 months ago) [maven-release-plugin] prepare release v5.0.0 - TheSnoozer (tag: v5.0.0)

For a full change-set review:
v5.0.0...version5.x

I also couldn't resist to add tests for java 11-20 and maven 3.1.0-alpha-1 -> 4.0.0-alpha-5.
Perhaps it would be worth to mention that this plugin currently requires a 3.1.0-alpha-1 and maven 4.X claims to support every maven 3.x plugin so in theory this plugin should work for maven 4.X.
However #622 already outlined that maven 4.X migght/will require maven 3.2.5. That update will only be shipped with plugin version 7.0.0 (yes another breaking version, since this plugin drops support for 3.1.X and 3.2.4 or smaller). This is all a bit unclear ATM, but I want to make sure that I do not backport any changes that are required to run on maven 4.X. As of now it seems to work, but might stop for whatever random reason.

Please feel free to raise any objections to the current change set in the version5.x branch.
I'll cut a 5.0.x once I have time - likely the next few days.

snicoll commented

Getting the Maven 3.9 warning fixed in 5.x would be very much appreciated, indeed. Thanks @TheSnoozer!

  • 👍1
xak2000 commented

Looks good to me! Thank you!

  • 👍1
TheSnoozer commented

Thanks for your patience with me.
The 5.0.1 version is now available on maven-central.
You can get this version via the usual dependency:

<dependency>
    <groupId>io.github.git-commit-id</groupId>
    <artifactId>git-commit-id-maven-plugin</artifactId>
    <version>5.0.1</version>
</dependency>

The only actual change is the backport of #616.

For a full change-set review:
v5.0.0...version5.x

As outlined above I'm not too sure if this version will be supported / work with maven 4.X. As of now it does, but it may stop for random reasons.

Let me know if you have any other questions and please feel free to raise any other problem or request as new issue :-)

Happy coding!

  • 👍1