> It looks like we need to trim `\r` from the output of `ssh-keygen -Y find-principals`'s on Windows, or we end up calling `ssh-keygen -Y verify` with a bogus signer identity, as per screenshot. [ssh-keygen.c:2841](https://github.com/openssh/openssh-portable/blob/master/ssh-keygen.c#L2841) seems to confirm this hypothesis. Signature verification passes with the fix.
lukaszibi opened this issue · 0 comments
lukaszibi commented
It looks like we need to trim
\r
from the output ofssh-keygen -Y find-principals
's on Windows, or we end up callingssh-keygen -Y verify
with a bogus signer identity, as per screenshot. ssh-keygen.c:2841 seems to confirm this hypothesis. Signature verification passes with the fix.
That looks like good material to put into the commit message.
As the DCO bot pointed out, you also need to add your Signed-off-by: trailer.
So: please amend the commit message with git commit -s
, providing a thorough commit message, and then force-push.
Originally posted by @dscho in git-for-windows/git#3561 (comment)