git-for-windows/git-sdk-64

Onboarded ``msgcat`` binary is broken

egeakman opened this issue · 4 comments

msgcat -o file.po file.po command produces syntax errors in .po files.

Turns

#: library/stdtypes.rst:419 library/stdtypes.rst:1171
#: library/stdtypes.rst:2397 library/stdtypes.rst:3615
msgid "\\(4)"
msgstr "\\(4)"

to

#: library/stdtypes.rst:419 library/stdtypes.rst:1171
#: library/stdtypes.rst:2397
 library/stdtypes.rst:3615
msgid "\\(4)"
msgstr "\\(4)"

which is syntactically wrong. However, on some files, it does keep it the correct way. The above example is from python/python-docs-tr (library/stdtypes.po).

It also adds whitespace at the top of the first msgid-msgstr pair.

# Python Documentation Turkish Translation
# Copyright (C) 2001-2023, Python Software Foundation
# This file is distributed under the same license as the Python package.
-#
+# 
msgid ""
msgstr ""

Using other binaries, however, doesn't produce any of these errors.

dscho commented

Is this an issue also with regular MSYS2?

Is this an issue also with regular MSYS2?

Tried it just now, and yes. Should I move this issue to https://github.com/msys2/MSYS2-packages?

dscho commented

Should I move this issue to https://github.com/msys2/MSYS2-packages?

Yes, I would strongly advise to do that.

Sorry, I didn't know about the other repo at the time.