github/branch-deploy

When there are no checks deployment isn't allowed

redoz opened this issue ยท 4 comments

redoz commented

Describe the Issue

A changeset that doesn't trigger any checks cannot be deployed;
image

We've changed one of our bicep files (and of course you could argue we should have a compile check on those, but we don't currently) and as such it doesn't let us deploy.

Action Configuration

      - name: Branch deployment
        id: branch-deploy
        uses: github/branch-deploy@v7.3.0
        with:
          # see https://github.com/github/branch-deploy#inputs-
          environment: qa # the default environment
          environment_targets: "qa"
          skip_reviews: "qa"
          environment_urls: "qa|https://qa.example.com"
          update_branch: disabled
          merge_deploy_mode: false
          stable_branch: master
          allow_forks: false
          environment_url_in_comment: true

Relevant Actions Log Output

No response

Extra Information

No response

@redoz I know why this is happening. Its a bug and you stumbled across it. Thank you for reporting! I will work on getting a new release out with the fix right away ๐Ÿ™‡

@redoz Fixed in release v7.3.1 ๐ŸŽ‰

redoz commented

@redoz Fixed in release v7.3.1 ๐ŸŽ‰

Will update tomorrow, thanks for the quick fix!

redoz commented

@GrantBirki Can verify that it now allows for deployments on PRs that have no checks. Awesome, thank you!