github/branch-deploy

`merge_deploy_mode = true` don't update the current branch deployed

jhkersul opened this issue · 2 comments

jhkersul commented

Details

Hi!

Every time a Pull Requests is merged, I'm deploying the stable branch to my development environment.

To do that, I'm using the property merge_deploy_mode = true and it works pretty well. However, it doesn't update the current branch deployed.

If I have an opened PR, it still shows as "deployed" even when it's not:

Screenshot 2023-09-04 at 13 17 33

Is there any way to fix that?

jhkersul commented

Ok, I forgot to pass environment to the job. Using something like this worked:

jobs:
  deploy:
    name: 'Deploy'
    environment: development
    runs-on: ubuntu-latest
    steps:
      - name: Branch Deploy
        id: branch-deploy
        uses: github/branch-deploy@v7.3.1
        with:
          merge_deploy_mode: "true"
          environment: development
# ...
Screenshot 2023-09-04 at 14 52 53
  • 👍1
GrantBirki commented

Glad that you were able to get it all sorted! It should be noted that there are some known bugs with the "Merge Deploy Mode" and I'm still trying to figure out how to resolve the issues.

#184

Looks like you got your specific issue resolved but just wanted you to be aware since I can see you are trying it out. Thanks!