Remove node_modules from Git
Closed this issue · 4 comments
These were originally added to ease deployment on Heroku but can easily become out of sync (partial fix in #561).
Instead, it would be preferable to remove node_modules from Git and instead use an additional Heroku build pack to ensure npm install is run before the application is run (e.g. https://stackoverflow.com/a/22850632/5355).
Note if this is done there will need to be some workaround to handle e.g. newer versions of Primer removing CSS rules that are used (e.g. alt-h0).
See #562 for a related PR.
This looks good @MikeMcQuaid. Thanks for looking into this. However, Site Engineering no longer owns this repo. As of August 2019 it has been transferred over to @github/developer-relations.
Circling back here. Who is an admin on this repo or can grant me access? I am unable to merge anything but happy to help.
update: nvm and disregard -- I saw Camps is grabbing these related repos https://github.com/github/ce-community-and-safety/issues/1401#issue-553704345
Assigning to @gallexi (not because it's on you to deal with this but you're so 💖 at triaging that I'm sure you'll get this with the right people)!