gitlab4j/gitlab4j-api

5.6.0 includes a breaking change in the API

MarkEWaite opened this issue · 2 comments

MarkEWaite commented

I believe that the API change of the fourth argument boolean (primitive type, nulls not allowed) to Boolean (object, nulls allowed) is a breaking change in pull request:

The change in the diff went from this:

    public ProjectHook addHook(Object projectIdOrPath, String url, ProjectHook enabledHooks,
            boolean enableSslVerification, String secretToken) throws GitLabApiException {

to this:

    public ProjectHook addHook(Object projectIdOrPath, String url, ProjectHook enabledHooks,
            Boolean enableSslVerification, String secretToken) throws GitLabApiException {

The Jenkins issue tracker received two reports of method not found exceptions in issue JENKINS-73672.

Is there a critical need for the change of type in the argument?

If not, could that change be reverted and a new release provided so that API compatibility is retained?

basil commented

Note that as of jenkinsci/gitlab-branch-source-plugin#438 consumers are actually depending on the new signature 😬

MarkEWaite commented

Closing this issue because the Jenkins plugin has updated to the 5.6.0 API and a revert to the 5.5.0 compatible API would be another breaking change.