Implement Parcelable.Creator in GithubComment

Question

Implement Parcelable.Creator in GithubComment

Closed this issue 8 years ago · 4 comments

Presently, GithubComment has a writeToParcel() implemented but no Parcelable.Creator. As a result, it ends up inheriting that from ShaUrl. So any GithubComment you put in the Parcel gets downcasted to ShaUrl resulting in a crash if you attempt to get a GithubComment from the Parcel.

aandis commented 8 years ago

👍

Answer 1 · 2016-03-04T19:39:45.000Z

Can you please open a PR for it?

Answer 2 · 2016-03-04T19:40:32.000Z

Just did! :)

Answer 3 · 2016-03-04T20:00:50.000Z

Version 3.2.3 uploaded to bintray