gizmore/gdo6

Session handling in index.php

flederohr opened this issue · 0 comments

PHP Warning(EH 2): mysqli_query(): (42000/3057): Incorrect user-level lock name ''. in GDO/DB/Database.php line 150

Backtrace starts in index.php line 146.
- GDO\DB\Database->unlock(false) ......................................... GDO/DB/Database.php line 439.
- GDO\DB\Database->queryRead("SELECT RELEASE_LOCK('&#…9;') as L") GDO/DB/Database.php line 137.
- GDO\DB\Database->query("SELECT RELEASE_LOCK('&#…9;') as L") .... GDO/DB/Database.php line 150.
- mysqli_query(mysqli, "SELECT RELEASE_LOCK('&#…9;') as L") ...... [unknown file] line ?.

I think the Database::instance()->unlock($lock); in index.php line 146 needs to be conditional with :

if (GDO_DB_ENABLED && GDO_SESS_LOCK && $method->isLockingSession()) {
     Database::instance()->unlock($lock);
}