gjaldon/heroku-buildpack-phoenix-static

Delete node_modules after compile

Closed this issue · 3 comments

There usually isn't any reason to include node_modules in your slug, so they should be nuked or it should at least be optional. It looks like compile runs after caching, so I'm going to add it to my compile step for now.

@aaronjensen doesn't the build directory need all of the app's deps in it? Have you tested this out?

Yes, see #36. It works well, my slug is 50mb smaller, which makes deployment a little faster and gives more room for assets and such.

Ahh, I get it now. The node modules are not necessary after compile because the assets have been built. We typically use Node just to build assets in Phoenix. This is definitely useful!