gkdr/axc

Call "session_builder_free(session_builder_p);" still uses internal libsignal-protocol-c non-API code

hartwork opened this issue · 5 comments

This is a follow-up to #16.

I just learned that aee726a is incomplete: There is one more call to non-API function session_builder_free at

axc/src/axc.c

Line 1051 in 27e0544

session_builder_free(session_builder_p);
Link errors brought this to my attention while trying to unbundle libsignal-protocol-c.
Is there a way to clean-up the session using public API?

Best, Sebastian

gkdr commented

thanks for pointing it out. i'll have a look, i'm sure it's doable via the public API.

(cringing at "line 1051"...)

gkdr commented

why do you think it's not part of the public API? the docs of session_builder.h make it seem like it's not only intended for internal use, and grepping it reveals that it's mentioned in the readme as well.

My bad, I think I jumped to conclusions too quickly here and should have double checked. No more link errors now, I think you're right. Closing as invalid.

PS: If you're interested, here's how I unbundled libsignal-protocol-c in Gentoo now: gentoo/gentoo@73f5dc7

gkdr commented

good to know, glad the issue was resolved so quickly.

i am interested, thanks for linking it 🙂