gkdr/axc

message_client.c does not compile

annerajb opened this issue · 3 comments

annerajb commented

It seems message_client.c is referencing old functions that are still on the .h files

axc_handshake_accept
axc_handshake_acknowledge

Are this suppose to be implemented are they needed?

gkdr commented

libsignal contained code for synchronous session establishment that was later removed.
I assume this is because you can use the existing asynchronous functions in a synchronous setting by simply sending a request for the data which usually gets uploaded to a server.

When I updated this library, I didn't update the demo code (because it seems this lib isn't too popular anyway, so I thought it's not a hurry. I wrote this on the readme:

Unfortunately it is currently broken as the synchronous code was removed.

In any case: No, they are not necessary, and compiling this demo is not necessary for the lib to work. But please leave this issue open as a reminder for me to fix it! Until then, I hope the documentation I wrote in the .h files is enough.

hartwork commented

@gkdr can this be closed as fixed? Seems to be fixed by commit 1c60f49.

  • 👍1
gkdr commented

4 years... better late than never 😬