Some suggestions
Opened this issue · 4 comments
Hi,
¡Thank you for develop this plugin!. I've been using the Publish plugin until now, but I think that the Approve plugin has some advantages over Publish.
Some things I miss:
- I would like to disable the "Approved $DATE by $USER (version X)" message for the read only users. If not possible, at least that we can choose the location of the message (for example, at the bottom of the page)
- I would like to change the "Approved $DATE by $USER" message (for example, to delete the $USER part or to translate the whole message).
- I would like to have the posibilty of approving all pending changes in one click.
Bye!
Hi,
a general quick win: You can style the display position and color of the banner by adding your styling to your local userstyle.css.
Hiding the approve message for r/o users and shortening it is basically (but fix, non-editable) implemented in https://github.com/mdiedrich-rz/dokuwiki-plugin-approve/tree/display_banner (not reviewed yet, my personal development). Comments are appreciated.
Approving all pending changes at once could be a good idea - in my opinion approving a page means viewing it, reading it, understanding it, thinking about it and then approving it (or not ;)). So batch processing isn't possible in that process and so normally not needed (perhaps for the first time after enabling the approve plugin). My approvement - my responsibility - my job to really review the changes. A question of processes to be defined :).
I'd just like to add another suggestion:
- Time based notification that a scheduled review is neccessary (perhaps after a configurable amount of time). I'll try to implement that in my branch too.
Bye and thanks for your suggestions :).
The time based notifications was implemented by my as watchcycle plugin some time ago. But it would be better if this feature is integrated into approve directly.
I would like to have the posibilty of approving all pending changes in one click.
Do you want to approve all pages without viewing the changes between revisions?
Thanks for your answers,
About "adding your styling to your local userstyle.css.": I tried to mantain dokuwiki "as standard as possible" to avoid problems with future updates. But is an alternative, thanks.
About "approve all pages": some scenarios where I think that this option would be useful:
- When the person who made the changes is the same that approve them, and is not possible to disable the plugin in that namespace (for example, when the plugin has been actived to comply with some regulation, in my case ISO 27001).
- When you active the plugin for the first time
- When you do a "batch editing" with the BatchEdit Plugin to change some strings in a lot of pages at once (not sure if this case would be detect as a new pending approval).
Publish plugin has an option for this, we use it from time to time.
Sounds reasonable. I believe we should include it in future releases.