glamod/glamod-nuim

Enhancement of daily codes

Closed this issue · 1 comments

sjnoone commented

I have enhanced bit of all the 3 daily codes and the utils.py files.

rjhd2 commented

PR #25 includes files from closed issue #20 in the commit. Maybe branched off branch.

This branch 20_daily_code_enhancement correctly only has changes to the 3 daily files and utils.

Intended solution

  • retain changed files (daily ones) locallly (in a temporary directory) just to be sure.
  • check out master and update (git pull)
  • check out this branch and update (git checkout 20_daily.... ; git pull). Should have edits from #7/#23 in it
  • make sure the edited files are still correct
  • make a new pull request and see if that's only got the single commit in it, continue from there.
  • close original pull request with a note to explain (open coding principles of Github means it always remains, but can just close)