T program no longer writes velocities to .kel files

Question

T program no longer writes velocities to .kel files

Opened this issue 3 years ago · 6 comments

Hello! Up until recently, the T program would write velocities (instead of frequencies) to the .kel file, when the -V and -W flags were used. I updated the analyze package a few months ago and just noticed that instead of velocities, frequencies (in Hz) are written instead, even though the labels within the .kel file say 'velocity.' I did a git pull this morning and see the same issue.

For example, you should see it if you run T with the data files that are provided in the complimentary data set (18-11-01T*...18-11-02T*) using the command below:
T -B -L -200 -H +200 -V -W 600 *
and other related commands, like:
T -W 600 *

When the .kel file is written, the data lists frequencies instead of velocities (see example below):

N Velocity Intensity

(m/sec) (Kelvins)

0000 1419981933 -0.4236

Note that T does, in fact, plot the velocity range correctly.
I dove into the code, but it's not obvious to me what to modify.
Could you please take a look? Thank you!

Answer 1 · 2022-05-25T17:59:54.000Z

Hi Dave, Sorry about any confusion. Now I’m wondering what happened. I think someone might have asked for frequencies instead of velocities. It should not be too hard to make the output match the requested plot type. Did you want all velocities in the spectrum or only the velocities plotted? The difference between the output files and the plots has been a little bit of a documentation headache. If frequencies, then all data were written+plotted. If velocities, only the selected velocities were plotted (and written?). Best regards Glen I’ve got lots of meetings, so this may take a day or two. Glen I Langston, Ph. D. Galactic Astronomy Program Director National Science Foundation 304-456-3032

…

On May 25, 2022, at 1:45 PM, dave290 ***@***.***> wrote: This email originated from outside of the National Science Foundation. Do not click links or open attachments unless you recognize the sender and know the content is safe. Hello! Up until recently, the T program would write velocities (instead of frequencies) to the .kel file, when the -V and -W flags were used. I updated the analyze package a few months ago and just noticed that instead of velocities, frequencies (in Hz) are written instead, even though the labels within the .kel file say 'velocity.' I did a git pull this morning and see the same issue. For example, you should see it if you run T with the data files that are provided in the complimentary data set (18-11-01T*...18-11-02T*) using the command below: T -B -L -200 -H +200 -V -W 600 * and other related commands, like: T -W 600 * When the .kel file is written, the data lists frequencies instead of velocities (see example below): N Velocity Intensity (m/sec) (Kelvins) 0000 1419981933 -0.4236 Note that T does, in fact, plot the velocity range correctly. I dove into the code, but it's not obvious to me what to modify. Could you please take a look? Thank you! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

Answer 2 · 2022-05-25T19:20:32.000Z

Hi Glen! Yes, it’s fine if only velocities within selected range are written to file. I think that’s the way it was before. Thank you so much, Dave On Wed, May 25, 2022 at 1:00 PM Glen Langston ***@***.***> wrote:

…

Hi Dave, Sorry about any confusion. Now I’m wondering what happened. I think someone might have asked for frequencies instead of velocities. It should not be too hard to make the output match the requested plot type. Did you want all velocities in the spectrum or only the velocities plotted? The difference between the output files and the plots has been a little bit of a documentation headache. If frequencies, then all data were written+plotted. If velocities, only the selected velocities were plotted (and written?). Best regards Glen I’ve got lots of meetings, so this may take a day or two. Glen I Langston, Ph. D. Galactic Astronomy Program Director National Science Foundation 304-456-3032 > On May 25, 2022, at 1:45 PM, dave290 ***@***.***> wrote: > > This email originated from outside of the National Science Foundation. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > Hello! Up until recently, the T program would write velocities (instead of frequencies) to the .kel file, when the -V and -W flags were used. I updated the analyze package a few months ago and just noticed that instead of velocities, frequencies (in Hz) are written instead, even though the labels within the .kel file say 'velocity.' I did a git pull this morning and see the same issue. > > For example, you should see it if you run T with the data files that are provided in the complimentary data set (18-11-01T*...18-11-02T*) using the command below: > T -B -L -200 -H +200 -V -W 600 * > and other related commands, like: > T -W 600 * > > When the .kel file is written, the data lists frequencies instead of velocities (see example below): > > N Velocity Intensity > > (m/sec) (Kelvins) > > 0000 1419981933 -0.4236 > > Note that T does, in fact, plot the velocity range correctly. > I dove into the code, but it's not obvious to me what to modify. > Could you please take a look? Thank you! > > — > Reply to this email directly, view it on GitHub, or unsubscribe. > You are receiving this because you are subscribed to this thread. > — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP25FZ2NER2I4STMX7GQWGTVLZTCLANCNFSM5W54UR5A> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Answer 3 · 2022-05-25T19:22:00.000Z

...Or, whichever is easier for you, in terms of which velocities are written to file.

Answer 4 · 2022-06-05T20:26:44.000Z

Hey Glen,

Just checking in about the velocity-writing issue with T.py
I have a student working on data analysis this summer and wanted to let her know when to update the analyze package.
No rush; if it's later, just let me know.

Thanks!
Dave

Answer 5 · 2022-06-12T17:28:59.000Z

Thank you so much for updating the code with the fix. Works just fine again!
Best,
Dave

Answer 6 · 2022-06-12T18:52:28.000Z

Hi Dave, Glad to hear I could help your student. We’re trying to expand our program to more high schools. It would be great if you could get us a few pictures of you, your telescope and some students. Thanks! Glen Glen I Langston, Ph. D. Galactic Astronomy Program Director National Science Foundation 304-456-3032

…

On Jun 12, 2022, at 1:29 PM, dave290 ***@***.***> wrote: This email originated from outside of the National Science Foundation. Do not click links or open attachments unless you recognize the sender and know the content is safe. Thank you so much for updating the code with the fix. Works just fine again! Best, Dave — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.