Hash Interface

Question

Hash Interface

glaslos opened this issue 7 years ago · 5 comments

Create an Hash compatible object for ongoing hashing.

Answer 1 · 2017-12-17T11:38:57.000Z

Although the Hash interface doesn't "fit" ssdeep so well - it has some functions that aren't really relevant for ssdeep (BlockSize for example), it's common in other languages (i'm coming from python) that a hash function satisfy the language standard for hasing.

Answer 2 · 2017-12-24T10:33:42.000Z

Generally a good idea. But how do you implement that you always have to provide the file size first? SetSize(int) or a Init()? io.Writer kinda makes only sense if your hash can be updated without prior knowledge about the final amount of data.

Answer 3 · 2017-12-24T11:22:23.000Z

Are we looking at the same Writer? I'm looking at this and the interface has only Write method.
I already implemented the hash interface, just need to make sure everything is working and push it.

Answer 4 · 2017-12-24T11:27:30.000Z

Okay, looking forward how you have done this :)

Answer 5 · 2018-01-05T08:35:55.000Z

We decided to not go for the Hash interface. See comments in the PR and more specific here: #15 (comment)