glaslos/ssdeep

Verify Distance Calculation

glaslos opened this issue · 2 comments

glaslos commented

Verify that the distance function is correct - looking at the code, it seems that the implementation is incomplete.

glaslos commented

This is still open. @davidt99 did you had some time to look into this?

davidt99 commented

Sorry, I was away from go for a while.
I checked the TODO in score.go and it's correct, the original implementation has the same logic, but I couldn't reproduce this in a test.
If you calculate it, the block size needs to be really small so the condition will be true...
I'll push what I did in a couple hours.