glaslos/ssdeep

Stable Release

davidt99 opened this issue · 5 comments

davidt99 commented

This issue is tracking the stuff that need to be done in order to have a stable release.
@glaslos feel free to reject/add stuff/discuss this with me. We are close to have this implementation usable for production.

What we need to do:

  • Create stateless api for fuzzy file and fuzzy bytes. I feel like the SSDEEP struct doesn't have much purpose.
  • Better documrntation.
  • More testing for integrity.
  • Verify that the distance function is correct - looking at the code, it seems that the implementation is incomplete.
glaslos commented

I do like the idea of using the Hash interface. It kind of conflicts with your stateless proposal.
Can you add some sub points to the documentation? What kind of information do you think would make sense to be added there?
Integrity testing as in making sure our output matches the one from the reference implementation?
Otherwise I agree with your proposal. Feel free to add individual issues so we can split up the conversation a bit.

  • 👍1
glaslos commented

I've split up all the issues and grouped them with a milestone: https://github.com/glaslos/ssdeep/milestone/1

davidt99 commented

I'll continue the discussion in the other issues.

ayoubfaouzi commented

Great work here, waiting for the stable release 👍

requaos commented

I do like the io.Writer on the Hash interface... was missing that for computing many hashes in parallel with io.MultiWriter + io.Copy